Skip to content

[SN-150] Model Evaluation SDK Method Notebook #1645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
May 31, 2024
Merged

[SN-150] Model Evaluation SDK Method Notebook #1645

merged 16 commits into from
May 31, 2024

Conversation

Gabefire
Copy link
Collaborator

@Gabefire Gabefire commented May 31, 2024 •
edited
Loading

Description

Created a notebook to be used for developer guides showcasing some of the new Model Evaluation project methods.

Type of change

  • Document change (fix typo or modifying any markdown files, code comments or anything in the examples folder only)

All Submissions

  • Have you followed the guidelines in our Contributing document?
  • Have you provided a description?
  • Are your changes properly formatted?

@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@github-actions github-actions bot requested a review from a team as a code owner May 31, 2024 18:07
@paulnoirel paulnoirel self-requested a review May 31, 2024 18:15
@Gabefire Gabefire requested a review from paulnoirel May 31, 2024 18:31
paulnoirel
paulnoirel reviewed May 31, 2024
View reviewed changes
examples/project_configuration/model_chat_evaluation_project.ipynb
@@ -0,0 +1,197 @@
{
Copy link
Contributor

@paulnoirel paulnoirel May 31, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dataset_name: The name of the dataset were the data rows" -> typo: "where"

"Optional description of your project." -> For consistency "The optional description of your project"

Suggestion: "A dataset ID of an existing Labelbox dataset." -> "An optional dataset ID of an existing Labelbox dataset."


Reply via ReviewNB

@paulnoirel paulnoirel self-requested a review May 31, 2024 18:50
paulnoirel
paulnoirel previously approved these changes May 31, 2024
View reviewed changes
Copy link
Contributor

@paulnoirel paulnoirel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@paulnoirel paulnoirel self-requested a review May 31, 2024 18:54
paulnoirel
paulnoirel approved these changes May 31, 2024
View reviewed changes
Copy link
Contributor

@paulnoirel paulnoirel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Gabefire Gabefire merged commit 9671e60 into develop May 31, 2024
4 checks passed
@Gabefire Gabefire deleted the gu/MOE_notebook branch May 31, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulnoirel paulnoirel paulnoirel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gabefire @paulnoirel